openfga / python-sdk

OpenFGA SDK for Python 3 - https://pypi.org/project/openfga-sdk/
https://openfga.dev
Apache License 2.0
38 stars 15 forks source link

fix: `list_users` should accept `FgaObject` type #99

Closed evansims closed 5 months ago

evansims commented 5 months ago

Description

This pull request fixes the ClientListUsersRequest class, which incorrectly accepts a str type for object rather than an FgaObject assignment. For consistency's sake, it also improves the type hinting of the other class properties.

References

Review Checklist

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.07%. Comparing base (664b0b9) to head (359ea33). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #99 +/- ## ========================================== + Coverage 68.06% 68.07% +0.01% ========================================== Files 114 114 Lines 8974 8969 -5 ========================================== - Hits 6108 6106 -2 + Misses 2866 2863 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

evansims commented 5 months ago

@rhamzeh @ewanharris Updated, thanks!