fix: `list_users` should accept `FgaObject` type

evansims commented 3 months ago

Description

This pull request fixes the ClientListUsersRequest class, which incorrectly accepts a str type for object rather than an FgaObject assignment. For consistency's sake, it also improves the type hinting of the other class properties.

References

Resolves #97

Review Checklist

[x] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.07%. Comparing base (664b0b9) to head (359ea33). Report is 2 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #99 +/- ## ========================================== + Coverage 68.06% 68.07% +0.01% ========================================== Files 114 114 Lines 8974 8969 -5 ========================================== - Hits 6108 6106 -2 + Misses 2866 2863 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

evansims commented 3 months ago

@rhamzeh @ewanharris Updated, thanks!

openfga / python-sdk