chore: add test to cover not sending empty array when other has data - Githubissues

openfga / sdk-generator

OpenFGA Client SDK Generator

Apache License 2.0

14 stars 30 forks source link

chore: add test to cover not sending empty array when other has data #306

Closed ewanharris closed 4 months ago

ewanharris commented 4 months ago

Description

For the Go, JS, and Python SDKs make passing no deletes or writes to the write command perform a no-op and just return an empty response

References

Part of #299 SDK PRs to come shortly

Review Checklist

[x] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

ewanharris commented 4 months ago

@rhamzeh I've updated the PR to include a Delete in tests for dotnet, go, js, and python.

Currently this isn't really valuable in SDKs where we're not matching the body in mocks, I'll spend some time tomorrow seeing if I can improve SDKs other than python a little further to validate this better.