feat(java-sdk): Allow global context for ListObjects

openfga / sdk-generator

OpenFGA Client SDK Generator

Apache License 2.0

14 stars 30 forks source link

feat(java-sdk): Allow global context for ListObjects #332

Closed Didier-SimpleCommeDev closed 3 months ago

Didier-SimpleCommeDev commented 3 months ago

Description

Fixes #331

Java SDK: Add support for global Context for the ListObjects API. The new field is optional and the change is backward compatible.

References

Review Checklist

[x] I have clicked on "allow edits by maintainers".
[X] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

linux-foundation-easycla[bot] commented 3 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: Didier-SimpleCommeDev (f4df632fa9b8be8fa21f8ce4fb276e1721331eb0)

Didier-SimpleCommeDev commented 3 months ago

Integration tests are KO for the Java SDK, but they seem to be KO on the main branch as well (at least locally). Same thing for another PR: https://github.com/openfga/sdk-generator/actions/runs/8343395905 Any hint is welcome :)

rhamzeh commented 3 months ago

May I ask you to rebase off main? This is fixed in #330

Didier-SimpleCommeDev commented 3 months ago

Rebase done, everything’s green, thanks! :)

Now I have to find a way to enrich the test for the feature. It doesn’t seem to be covered in .Net or Python as far as I can tell (only contextual tuples, not global context) so building a test case may prove challenging.

@rhamzeh : please let me know if I have to push further – might need some assistance though

rhamzeh commented 3 months ago

@Didier-SimpleCommeDev for the sake of unblocking this PR, we're going to merge it as is! Thanks for the fix.

@jimmyjames and @ewanharris are looking into updating our tests to make testing this easier, but there's no reason to block this fix until then.

Thank you for the contribution!

Didier-SimpleCommeDev commented 3 months ago

@rhamzeh : Thanks for letting it through :)