openfga / vscode-ext

An OpenFGA extension for VS Code
https://openfga.dev
Apache License 2.0
13 stars 4 forks source link

Remove Language Server and Syntax Transformer related parts #4

Closed rhamzeh closed 1 year ago

d-jeffery commented 1 year ago

Trimmed down service code, disabling all functionality, and removed dependencies on syntax-transformer

The created theme appears to apply to all languages, but is scoped only to openfga files. This removes the majority of syntax highlights from other files, while the theme was active.

rhamzeh commented 1 year ago

What do we need to do in order to apply it only to OpenFGA files?

d-jeffery commented 1 year ago

Fix the grammar so it follows TextMate conventions: https://macromates.com/manual/en/language_grammars

As I can see, a lot of the standard name labels are backwards (i.e. from.keyword, instead of keyword.from). Doing this will provide a standard syntax coloring out of the box, which you can customize with a preferred theme, as you're currently doing.

But the theme is a problem as well. When active, since everything is scoped to openfga, none of the coloring is applied to any other file type. This is why the openfga-dark works for openfga currently.