openfheorg / openfhe-development

This is the development repository for the OpenFHE library. The current (stable) version is v1.2.3 (released on October 30, 2024).
BSD 2-Clause "Simplified" License
761 stars 190 forks source link

Should we make CMAKE exit when building with emscripten on 128 bits? #277

Closed iquah1 closed 1 year ago

iquah1 commented 1 year ago

TL;DR The description in the README and actual behavior do not line up

See message(SEND_ERROR "NATIVE_SIZE == 128 is not supported for EMSCRIPTEN")

Motivation

I had 128-bit set and when I built the emscripten as per palisade-wasm I didn't actually error out.

dsuponitskiy commented 1 year ago

This was fixed for https://github.com/openfheorg/openfhe-development/pull/240