search

openfheorg / openfhe-development

This is the development repository for the OpenFHE library. The current (stable) version is v1.2.0 (released on June 25, 2024).
BSD 2-Clause "Simplified" License
663 stars 170 forks source link

blake2engine: Use .data() to get pointer to data and not .begin() #742

Closed autoantwort closed 2 months ago

autoantwort commented 2 months ago

.begin() could return an iterator object depending on the build context

yspolyakov commented 2 months ago

@autoantwort We typically create issues and discuss them before creating PRs. I see many small PRs from you (which is overwhelming), and their motivation is not clear. My suggestion is to create one PR with all small fixes/cleanups, and we can later discuss these together. For the time being, I will close the PRs that have been open.

autoantwort commented 2 months ago

So you prefer one big PR with many unrelated changes instead of one PR per concern? Should I create one Issue for every PR / Concern or one Big one?

yspolyakov commented 2 months ago

I suggest discussing the problem first. We want to understand the motivation before reviewing the PRs. Many PRs appeared very small. You can create an issue for each separate problem. A PR can afterwards be created for multiple issues.

autoantwort commented 2 months ago

I have created #770