openfheorg / openfhe-development

This is the development repository for the OpenFHE library. The current (stable) version is v1.2.0 (released on June 25, 2024).
BSD 2-Clause "Simplified" License
663 stars 170 forks source link

Add library to vcpkg #770

Open autoantwort opened 2 months ago

autoantwort commented 2 months ago

According to https://github.com/openfheorg/openfhe-development/pull/742#issuecomment-2067298817: To make it easier to use the library I wanted to bring the lib to vcpkg. While doing so, I noticed some areas that could be improved, mainly by trying to compile with msvc, but that only made the errors visible.

https://github.com/openfheorg/openfhe-development/pull/742: The begin function could return an iterator object depending on your build settings (for example debug msvc, but you can also do this with gcc and clang).

https://github.com/openfheorg/openfhe-development/pull/743: Why using compiler specific extensions when there are standard attributes?

https://github.com/openfheorg/openfhe-development/pull/744: Finish refactoring that you started. Also fixes the msvc build.

https://github.com/openfheorg/openfhe-development/pull/746: Detected while compiling for android.

https://github.com/openfheorg/openfhe-development/pull/747: On the way to msvc support.

https://github.com/openfheorg/openfhe-development/pull/748: Nicer way to define _USE_MATH_DEFINES. The the include order is also not important. (If i include math.h before your header your header is currently broken.)

https://github.com/openfheorg/openfhe-development/pull/749: Use the c++ implementation as fallback, allows msvc support.

https://github.com/openfheorg/openfhe-development/pull/750: No need to rely on bash if there is an cmake builtin for it