search

openfheorg / openfhe-python

Official Python wrapper for OpenFHE. Current release is v0.8.8 (released on June 25, 2024).
https://openfheorg.github.io/openfhe-python/html/index.html
BSD 2-Clause "Simplified" License
62 stars 18 forks source link

Add initial unit tests #53

Closed yspolyakov closed 2 months ago

sei-adolgert commented 6 months ago

Hi Rener and Yuriy. Could I help with this? What I see for a first task is: Rename the "test" directory to "tests" so it agrees with Python's usual name. Make a pytest that is a "smoke test" so it just imports the library. Then setup pytest to take a command-line argument so that the default is a short set of tests (to run on Github) and a flag for longer set of tests (because there's no way Github will run FHE workloads that are more than very short). Does that sound like a start?

reneroliveira commented 5 months ago

Hi Rener and Yuriy. Could I help with this? What I see for a first task is: Rename the "test" directory to "tests" so it agrees with Python's usual name. Make a pytest that is a "smoke test" so it just imports the library. Then setup pytest to take a command-line argument so that the default is a short set of tests (to run on Github) and a flag for longer set of tests (because there's no way Github will run FHE workloads that are more than very short). Does that sound like a start?

@sei-adolgert sounds like a good ideia, for sure!

sei-adolgert commented 5 months ago

Rener, thanks for the message. I made a PR with a first commit. It's a way to say, yes, this is on the right track, for something small. Or, no, not the right track. Are you able to review a PR? https://github.com/openfheorg/openfhe-python/pull/103

yspolyakov commented 4 months ago

@sei-adolgert Could you create another PR adding some documentation about running the tests to the main README.md file and then pointing to tests/README.md for more details.