search

openfheorg / openfhe-python

Official Python wrapper for OpenFHE. Current release is v0.8.8 (released on June 25, 2024).
https://openfheorg.github.io/openfhe-python/html/index.html
BSD 2-Clause "Simplified" License
60 stars 18 forks source link

Update advanced-real-numbers.py #83

Closed Laura-Ball closed 7 months ago

Laura-Ball commented 8 months ago

I think you want "result" to be the decryption of "c_res_hoist" here, when you are printing the results with hoisting. (Right now, you have "result" as the decryption of "c_res_no_hoist" twice, both here and above, when you are printing the results both with and without hoisting.)

reneroliveira commented 7 months ago

Hello, thanks for your correction. Can you redo the same commit to the dev branch? We don't have a contributing guide yet but the desired flow is to commit to the dev branch, and then we release it together with other features.

We can do the correction in the dev branch, but if you do it on your side, your name will be included in the commit history.

Laura-Ball commented 7 months ago

Oh, that is courteous of you. Sure: I've just requested to merge into the dev branch instead.