search

openfisca / country-template

Start modelling the tax and benefit system of your country in a few minutes.
https://legislation.demo.openfisca.org
GNU Affero General Public License v3.0
33 stars 15 forks source link

Linting issue in new country template #131

Closed verbman closed 1 year ago

verbman commented 1 year ago

Hi there!

I really enjoy OpenFisca, but I recently encountered an issue.

Here is what I did:

Created a new country repository from the OpenFisca country template

Here is what I expected to happen:

The linting tests to pass when I ran make test locally

Here is what actually happened:

The linting tests failed

Here is data (or links to it) that can help you reproduce this issue:

I believe the issue originates in the setup.cfg file as it still references openfisca_country_template on lines 17,18 and 36 in my new country repository created utilising the bootstrap.sh script from the openfisca_country_template repository.

The way to resolve this issue will be to edit the bootstrap.sh to include setup.cfg - perhaps on line 39 as per the following untested suggestion:

sed -i.template "s|country_template|$lowercase_country_name|g" README.md setup.py setup.cfg .github/workflows/workflow.yml Makefile MANIFEST.in $all_module_files

Context

I identify more as a: