openfisca / country-template

Start modelling the tax and benefit system of your country in a few minutes.
https://legislation.demo.openfisca.org
GNU Affero General Public License v3.0
33 stars 15 forks source link

Automate template setup process via CI for GitHub users #143

Closed Ndpnt closed 6 months ago

Ndpnt commented 6 months ago

These changes:

The automation of template setup process via CI can be tested on my fork here

Ndpnt commented 6 months ago

This PR will imply to update the expected validations in the branch protection settings.

MattiSG commented 6 months ago

I have switched off required status for all status checks except check-version-and-changelog 👍

Ndpnt commented 6 months ago

One question though: I see that the current workflow layout has a nested build job, and it is the only nested one. Do you understand where this is coming from? Is there any way we can make it appear at the same level as other entries in the build?

image

I'm unsure why, and I don't know how to change it. My guess is that this arises because the build job is defined within the build workflow file, and this job is triggered only as a dependency of other workflows, not directly.

MattiSG commented 6 months ago

My guess is that this arises because the build job is defined within the build workflow file, and this job is triggered only as a dependency of other workflows, not directly.

That makes sense… let's try to find a workaround this UI limitation and rename one or the other to make it look clearer 🙂

Ndpnt commented 6 months ago

That makes sense… let's try to find a workaround this UI limitation and rename one or the other to make it look clearer 🙂

What do you think if we rename the job build into build-and-cache?

MattiSG commented 6 months ago

rename the job build into build-and-cache?

Very good idea, as indeed the goal is to cache and fill in the dependency for all other steps! Let's make sure that this is the name of the top-level entry though, so I assume this should be the name of the workflow and not job (but I'm not sure).

Ndpnt commented 6 months ago

Very good idea, as indeed the goal is to cache and fill in the dependency for all other steps! Let's make sure that this is the name of the top-level entry though, so I assume this should be the name of the workflow and not job (but I'm not sure).

I'm not sure to understand, what do you prefer build / build-and-cache or build-and-cache / build?

MattiSG commented 6 months ago

Thanks for pointing that out… I prefer build / build-and-cache even though I initially suggested the opposite 😅

Ndpnt commented 6 months ago

Thanks for pointing that out… I prefer build / build-and-cache even though I initially suggested the opposite 😅

Ok so I properly understood 😄. I also prefer build / build-and-cache

MattiSG commented 6 months ago

As discussed synchronously:

image