search

openfisca / legislation-explorer

Explore legislation formulas and parameters.
https://legislation.demo.openfisca.org
GNU Affero General Public License v3.0
26 stars 12 forks source link

Improve readability for Variables #106

Closed Anna-Livia closed 7 years ago

Anna-Livia commented 7 years ago

Fixes #79

This PR :

EDIT by @fpagnoux:

Depends on https://github.com/openfisca/openfisca-doc/pull/80

Anna-Livia commented 7 years ago

Todo :

1

a1d8571

1

For variables with no formula, remove title 'Formule de calcul'

fpagnoux commented 7 years ago

when would be the best time to do a rebase

When the PR is approved, before merging :)

fpagnoux commented 7 years ago

You probably just need a small adaptation of the tests to pass them.

Replacing "dd:nth-of-type(2)" by p:nth-of-type(2) in tests/integration/VariableComponent.js should probably be enough.

fpagnoux commented 7 years ago

Code is ready to merge, but waiting for https://github.com/openfisca/openfisca-doc/pull/80/files to be merged.

@Anna-Livia @MattiSG @sandcha , can one of you review this PR 🙂 ?