Closed MattiSG closed 6 years ago
Glad to see this app once limited to France going global 🙂
I'm rusty on this codebase, but the change seem sensible to me, and the result is definitely an improvement (tested with a French and English browser.)
One limitation of this configuration system is that we can't work in development mode with any country other that the country template. That is not per se a regression, as before this used to be possible only for OpenFisca France, but I hope we can improve that in the future.
Consequently, the command npm run dev:prod-api
doesn't make much sense anymore, as it uses the France web API but country template config elements. I removed it.
we can't work in development mode with any country other that the country template
Oh, we can! This is how I run in dev with actual data: API_URL='https://fr.openfisca.org/api/v21' npm run dev
🙂
I agree that npm run dev:prod-api
was bad though, but there is a bigger piece of work that's needed for the config loading mechanism to be internationalised.
Oh, we can! This is how I run in dev with actual data: API_URL='https://fr.openfisca.org/api/v21' npm run dev 🙂
Not entirely, as openfisca/country-template
and the development environment
will still be used from the config
This changeset localises all textual elements as well as the format of dynamic values.
Many dynamic values (dates especially) were not properly formatted, even in the original French language.
It also:
It is worth noting that:
Screenshots for main changes
Header
Before
After —
fr-FR
After —
en-US
Parameter view
Before
After —
fr-FR
After —
en-US
Scale view
Before
After —
fr-FR
After —
en-US
Fix #146.