Closed bonjourmauko closed 6 years ago
According to https://stackoverflow.com/questions/43289348 this is probably because some dependency is still using React.PropTypes. I feel that this PR would be complete only if the warning is removed.
It would be an improvement to merge as such, but I'm afraid the warning left without obvious reason will actually make it harder for future implementers to understand the cause of it.
Hi @MattiSG !
Actually, these changes do not come from the warnings, but from me wanting to upgrade the app's dependencies and to do some cleanup.
I understand, what I'm telling you is that the app dependencies can't currently be upgraded 😉
Not blocking, but not approving until understanding of the origin of the warning has been obtained.
Haven't found the origin yet.
react-router
 !
Oh! Ok I'll take a look.
swagger-ui
!
@maukoquiroga FYI, there is a linter alert It would be good to change it before rebase & merge :)
/Users/octo-ango/Desktop/Anna-Livia/openfisca/originals/legislation-explorer/src/history.js
6:3 error Newline required at end of file but not found eol-last
Hi @Anna-Livia, I can't find that file in the the repository.
These changes are required if we want to upgrade our app's React version.