search

openfisca / legislation-explorer

Explore legislation formulas and parameters.
https://legislation.demo.openfisca.org
GNU Affero General Public License v3.0
26 stars 12 forks source link

Use prop-types as React.PropTypes is deprecated #161

Closed bonjourmauko closed 6 years ago

bonjourmauko commented 6 years ago

These changes are required if we want to upgrade our app's React version.

MattiSG commented 6 years ago

According to https://stackoverflow.com/questions/43289348 this is probably because some dependency is still using React.PropTypes. I feel that this PR would be complete only if the warning is removed.

It would be an improvement to merge as such, but I'm afraid the warning left without obvious reason will actually make it harder for future implementers to understand the cause of it.

bonjourmauko commented 6 years ago

Hi @MattiSG !

Actually, these changes do not come from the warnings, but from me wanting to upgrade the app's dependencies and to do some cleanup.

MattiSG commented 6 years ago

I understand, what I'm telling you is that the app dependencies can't currently be upgraded 😉

bonjourmauko commented 6 years ago

Not blocking, but not approving until understanding of the origin of the warning has been obtained.

Haven't found the origin yet.

bonjourmauko commented 6 years ago

react-router !

bonjourmauko commented 6 years ago

Oh! Ok I'll take a look.

bonjourmauko commented 6 years ago

swagger-ui!

Anna-Livia commented 6 years ago

@maukoquiroga FYI, there is a linter alert It would be good to change it before rebase & merge :)

/Users/octo-ango/Desktop/Anna-Livia/openfisca/originals/legislation-explorer/src/history.js
  6:3  error  Newline required at end of file but not found  eol-last
bonjourmauko commented 6 years ago

Hi @Anna-Livia, I can't find that file in the the repository.