openfisca / legislation-explorer

Explore legislation formulas and parameters.
https://legislation.demo.openfisca.org
GNU Affero General Public License v3.0
26 stars 12 forks source link

Proposal turn on dependabot #166

Closed Br3nda closed 6 years ago

Br3nda commented 6 years ago

I use @dependabot to quickly send me PRs of security upgrades in package.json Then the tests can run and generally the fix is low effort.

Let's turn it on here, so we have git master patched quickly after an advisory.

MattiSG commented 6 years ago

Thanks @Br3nda for the suggestion! I had a look at https://github.com/ServiceInnovationLab/legislation-explorer/pulls to see the impact of enabling dependabot.

While I am impressed with the bot itself, I am honestly feeling like this would hardly be manageable in the current resource context of this codebase. If I am to spend time updating dependencies, I would rather spend it removing as many as possible, as the whole webpack pipeline for example is out of control.

I at least can't personally commit to handling incoming updates. Is there anyone around @openfisca/core-contributors who could?

fpagnoux commented 6 years ago

Some dependencies are definitely getting very old, but yeah, I don't think I'd either have the bandwidth to systematically upgrade all our dependencies...

For instance, upgrading from webpack 1 to webpack 3 doesn't seem trivial to me.

Damned, we are so out of date that it became really hard to get up to date again. 😞

MattiSG commented 6 years ago

REMOVE WEBPACK 😜

Br3nda commented 6 years ago

I'll go ahead and configure it. If there are good enough tests, then it can be a very low effort - certainly less effort than patching manually.

Br3nda commented 6 years ago

ah, i don't have access to add app to an organisation. someone will need to do it. https://github.com/marketplace/dependabot

bonjourmauko commented 6 years ago

@Br3nda I just did:

capture d ecran 2018-08-16 a 16 21 20

Please let me know if you have any further issues.

Br3nda commented 6 years ago

@maukoquiroga You can configure it to just do security patches - and also to just do lock file changes.

bonjourmauko commented 6 years ago

I did:

capture d ecran 2018-08-20 a 15 11 08 capture d ecran 2018-08-20 a 15 10 50

Do you think we can close the issue?