New slash syntax in parameters is not supported

openfisca / legislation-explorer

Explore legislation formulas and parameters.

https://legislation.demo.openfisca.org

GNU Affero General Public License v3.0

26 stars 12 forks source link

New slash syntax in parameters is not supported #169

Closed MattiSG closed 6 years ago

MattiSG commented 6 years ago

As shown in https://saucelabs.com/jobs/56e91565aad14feb98de97c7862b9e19, the new slash syntax for parameters introduced in some new version of the web API breaks the legislation explorer. It prevents the router from loading the page altogether.

This is a major problem for the Legislation Explorer as its integration tests are currently based on the French API, and @openfisca/france-admin have deployed this latest version live, which means that all tests will now fail, preventing merges.

This new slash syntax should be supported, as it is apparently the new way to navigate parameters. This also underlines the need to isolate tests from any live environment.

Anna-Livia commented 6 years ago

The problem seems to be due to the /parameters page --> This parameter list defines the routing of the LegExp. When we changed the key from "cotsoc.gen.smic_h_b" to "cotsoc/gen/smic_h_b", the routing module looks for a parameter called "cotsoc" and doesn't find it.

Step one : Roll back the openfisca-core dependency used in api/v21 so the LegExpl functions again.
Step Two : Create api/v22 with the latest core/france dependencies
Step Three : Open a PR to update the Leg Exp to be compatible with the new Core.

I hope this will help :)

fpagnoux commented 6 years ago

The problem seems to be due to the /parameters page

Humm, all the side-effect on /parameters were not really intented, ar ot least not thought trough.

You're right, let's roll back and see what we do next.

Anna-Livia commented 6 years ago

Roll back is done, and there is now a v22 api with the new core available for tests :)

Anna-Livia commented 6 years ago

@MattiSG I feel that we can close the issue.

This also underlines the need to isolate tests from any live environment.

I agree, I opened an issue on the subject so we can discuss how to go about it : openfisca/legislation-explorer#170

fpagnoux commented 6 years ago

@MattiSG I feel that we can close the issue.

Currently, the legislation explorer is still not compatible with the latest version of Core. Until this is fixed, this issue should probably stay open.

fpagnoux commented 6 years ago

Fixed by https://github.com/openfisca/openfisca-core/pull/710