openfisca / legislation-explorer

Explore legislation formulas and parameters.
https://legislation.demo.openfisca.org
GNU Affero General Public License v3.0
26 stars 12 forks source link

Change wording of back button and keep search query across navigation #57

Closed cbenz closed 7 years ago

cbenz commented 7 years ago

Fixes #54

MattiSG commented 7 years ago

Issue: if I arrive on the details page from a direct link, this “go back” button doesn't mean anything to me. Solution: “See the ${research results count - 1} other variables and parameters”.

MattiSG commented 7 years ago

Please don't force-push while in the review process. This makes it impossible to track changes since last review, thus making the reviewer's job very hard.

cbenz commented 7 years ago

@MattiSG I tested by replacing this line by:

-  return concat(matchesInName, matchesInDescriptionOnly)
+  return [concat(matchesInName, matchesInDescriptionOnly)[0]]

Here is the result:

image

image