search

openfisca / legislation-explorer

Explore legislation formulas and parameters.
https://legislation.demo.openfisca.org
GNU Affero General Public License v3.0
26 stars 12 forks source link

Improve the search algorithm #59

Closed cbenz closed 7 years ago

cbenz commented 7 years ago

Connected to #52

cbenz commented 7 years ago

Rendered as;

edit: the purple highlight is from Firefox, not from the application

image

cbenz commented 7 years ago

Sorry, I didn't tell but this highlight is just Firefox one, and was intended to help the reviewers to evaluate the algorithm.

I could add a real highlight though.

MattiSG commented 7 years ago

this highlight is just Firefox one

Aaah ok, since you wrote “rendered as” I thought this was the actual rendering :)

MattiSG commented 7 years ago

I could add a real highlight though.

Would be cool, but not in this PR, and definitely not overriding any of the other prioritised items in this sprint 😉

cbenz commented 7 years ago

I tried to make the search algo more understandable, please tell me if that's better.

MattiSG commented 7 years ago

It seems there was an issue with diff rendering in GitHub, I just commented on stuff you had already fixed 😕

cbenz commented 7 years ago

The ascend function was added in a recent version of Ramda.js.

@MattiSG The node_modules directory on your machine may not have been updated by npm install for some weeks.

The continuous integration does npm install from scratch so this problem was not caught. Adding tests wouldn't have either.

That's the job for a prebuild package.json script, I'll add it later.

MattiSG commented 7 years ago

Should get a bonus for exact match:

capture d ecran 2017-02-28 a 14 56 10

I leave it up to you to see if this is included in this PR or not.