search

openfisca / legislation-explorer

Explore legislation formulas and parameters.
https://legislation.demo.openfisca.org
GNU Affero General Public License v3.0
26 stars 12 forks source link

Update dependencies before build in deployment script #60

Closed cbenz closed 7 years ago

cbenz commented 7 years ago

This improves resilience of continuous deployment script (introduced in #50), in the case there is a need to update the dependencies.

I could have added a npm install line in deploy_prod.sh before npm run build, but the prebuild script is less specific.

cbenz commented 7 years ago

@MattiSG What about adding a npm install line in deploy_prod.sh before npm run build, then? This script is only for CircleCI which is not offline.

This PR aims to improve resilience of deploy-to-production.

MattiSG commented 7 years ago

Yes, in this case you need to add it to the deployment script. This is not so much of increasing resilience as actually fixing the process, I believe :wink:

MattiSG commented 7 years ago

Merging with “changes requested” is not very nice 😕

cbenz commented 7 years ago

I understood in your previous comment that it's OK to add npm install line in deploy_prod.sh before npm run build. That's what I did, did you notice?

MattiSG commented 7 years ago

Yes, I did notice, but only after a diff double-check. It is not a good habit to take to merge without a green tick — you never know when the agreement was clear for everybody 🙂 In this case it was, and there was no harm done, but I'd really prefer we don't rely on that :wink: