search

openfisca / legislation-explorer

Explore legislation formulas and parameters.
https://legislation.demo.openfisca.org
GNU Affero General Public License v3.0
26 stars 12 forks source link

A value of 0 is presented as a removal from legislation #74

Closed cbenz closed 7 years ago

cbenz commented 7 years ago

On https://legislation.openfisca.fr/impot_revenu.autre.finpfl

image

The API returns a boolean: https://api-test.openfisca.fr/parameter/impot_revenu.autre.finpfl

But this condition uses ! value abusively, which matches the false.

Meta: @fpagnoux @MattiSG What could we do to avoid this from now?

MattiSG commented 7 years ago

What could we do to avoid this from now?

Enforce the use of either === or our brain :wink:

Thanks for pinpointing the failure, the fix will be easy.