search

openfisca / legislation-explorer

Explore legislation formulas and parameters.
https://legislation.demo.openfisca.org
GNU Affero General Public License v3.0
26 stars 12 forks source link

Internationalise site header #96

Closed sandcha closed 7 years ago

sandcha commented 7 years ago

Connected to #72

Translate site header message according to browser language. (Set default language to french and define translations in json files.)

fpagnoux commented 7 years ago

✅ I get the english version, if I set my browser language to English.

fpagnoux commented 7 years ago

There is an error:

Uncaught TypeError: e.messages.get is not a function
    at a (client.jsx:43)
    at Object.<anonymous> (client.jsx:56)
    at e (bootstrap dc2bd8f…:19)
    at bootstrap dc2bd8f…:39
    at bootstrap dc2bd8f…:39

This is what make the tests fail.

fpagnoux commented 7 years ago

I tried to push a fix

fpagnoux commented 7 years ago

Rebasing and merging

MattiSG commented 7 years ago

Has this been cross-browser tested?

sandcha commented 7 years ago

Yes, cross-browser tested.

bonjourmauko commented 6 years ago

How did you cross-browser tested it? The way to set accept-language changes by the driver chosen, and I think it can't be set in IE. We assume it to be en-US?