openfisca / openfisca-core

OpenFisca core engine. See other repositories for countries-specific code & data.
https://openfisca.org
GNU Affero General Public License v3.0
168 stars 75 forks source link

Drop latest NumPy supported version to 1.18 #1014

Closed bonjourmauko closed 3 years ago

bonjourmauko commented 3 years ago

Fixes #1009 Supersedes #1012 Depended on by #1010

Bug fix

bonjourmauko commented 3 years ago

Thanks a lot @sandcha !

I see that this PR isn't the method that we chose with @benjello and @guillett (!= method 2️⃣ on slack) but it was before you analysed was we did in the past for a similar situation and I agree that this way is cleaner (and doesn't introduce a new way of managing unpublished revisions with its risks).

Again thanks a lot for your proactiveness to try to find a way to unblock users 😃

There are a couple of factors that convinced me to propose this way of dealing with the issue, and here instead of Slack:

  1. As you mention, it seems that we already have a way of dealing with this situation, but its documentation is largely absent. In general, I think that the whole corpus of previous decisions is an asset we have to take into account —referring to the "jurisprudence" more often and calling "referendums" only in case of dissent as a subsidiary decision-making strategy.

  2. In parallel, I feel the boundary between Github's and Slack's role is rather blurry. This proposal is thus motivated by the following hypothetical rule-of-thumb:

  1. Finally I think the fact that we already lack a clear process for maintenance/contribution (#1004) makes it the much more undesirable to further increase information and participation asymmetry: how to weight my opinion, yours, @guillett's, @benjello's, etc., expressed over a semi-public space, in a thread, regarding the whole of the core's users' and contributors' in the context of a decision that will likely impact them all? —it is at least here more a question of transparency than legitimacy, otherwise I wouldn't be writing this comment myself.

This issue is rather easy because of 1. supra —I cheated! 🤣— but others won't be so.