Closed bonjourmauko closed 3 years ago
Thanks a lot @sandcha !
I see that this PR isn't the method that we chose with @benjello and @guillett (!= method 2️⃣ on slack) but it was before you analysed was we did in the past for a similar situation and I agree that this way is cleaner (and doesn't introduce a new way of managing unpublished revisions with its risks).
Again thanks a lot for your proactiveness to try to find a way to unblock users 😃
There are a couple of factors that convinced me to propose this way of dealing with the issue, and here instead of Slack:
As you mention, it seems that we already have a way of dealing with this situation, but its documentation is largely absent. In general, I think that the whole corpus of previous decisions is an asset we have to take into account —referring to the "jurisprudence" more often and calling "referendums" only in case of dissent as a subsidiary decision-making strategy.
In parallel, I feel the boundary between Github's and Slack's role is rather blurry. This proposal is thus motivated by the following hypothetical rule-of-thumb:
OpenFisca's Slack is an éphémère space for mingling, exchange, cross-pollination, etc. Being éphémère renders it IMHO unsuitable for documenting decisions —hence not "opposable".
OpenFisca's Slack is also underrepresented when it comes to the core, most of the public discussions (23% of total) being held in the context of the country models. Thus I'm not even sure it is a suitable place for product decision-making.
Regarding that previous point: what works for example with France, where we can today with confidence have in a same call a decent amount of contributor's representation, the same does not hold yet true for the core.
This issue is rather easy because of 1. supra —I cheated! 🤣— but others won't be so.
Fixes #1009 Supersedes #1012 Depended on by #1010
Bug fix
__future__.annotations
, those stubs or type sheds are casted totyping.Any
typing.TYPE_CHEKING
variablenumpy.typing
module was being imported at runtime, rendering OpenFisca unusable to all users depending on previous versions of NumPy (1.20.x-)