Run country & extension template tests systematically

openfisca / openfisca-core

OpenFisca core engine. See other repositories for countries-specific code & data.

https://openfisca.org

GNU Affero General Public License v3.0

168 stars 75 forks source link

Run country & extension template tests systematically #1020

Closed bonjourmauko closed 2 years ago

bonjourmauko commented 3 years ago

Relates to #1021 openfisca/openfisca-france#1649

Technical changes

Run openfisca-core & country/extension template tests systematically
- Changes to openfisca-core can unintendedly break packages depending on it
- The country/extension templates are useful to avoid most of these situations
- These changes provide a way to run them systematically, both locally and in CI
- Bonus: it only uses openfisca test 😉

bonjourmauko commented 3 years ago

Ok with the feature creep 😄 , I'll split things up.

MattiSG commented 3 years ago

Thanks @maukoquiroga!

benjello commented 3 years ago

Hello @MattiSG @maukoquiroga : this PR stands in the way of some other PRs. Shouldn't we merge it ASAP or do you plan an overhaul of what is fixed here ?

bonjourmauko commented 3 years ago

I think it is safe to merge this one.

benjello commented 3 years ago

@MattiSG does it LGTM for you ?

MattiSG commented 2 years ago

I am surprised to discover that my approving review was dismissed two weeks ago. Review time is precious, and I feel frustrated that I have to review one more time and that this PR was involuntarily blocked for so long.

@maukoquiroga according to the GitHub logs, my review was dismissed through a commit of yours. Did you have any specific action towards that goal? If so, could you share what was your intention? 🙂 If not, do you have an idea why your commit dismissed my review?

bonjourmauko commented 2 years ago

@MattiSG I think we just changed settings to dismiss stale reviews after #990. I've just deactivated it for now.

MattiSG commented 2 years ago

As seen over the phone with @maukoquiroga, the experiment of auto-dismissing stale reviews started after #990 turns out to be too much of a hassle in our process where we almost systematically rebase before merging and where reviews are very asynchronous.