Switch from CircleCI to GitHub Actions

[HAEKADI]

Technical changes

• Switch CI provider from CircleCI to GitHub Actions

To Do:

• [x] Test deploy
• [x] Add PyPI password and CircleCI token to GitHub Actions

Once Openfisca-doc has migrated to GitHub Actions as well, the use of CircleCI API to update the doc should be changed as well.

[HAEKADI]

The test-core job fails if the build is not incorporated in the same job. I have no idea why. When running pytest alone, the yaml tests fail with a file not found error. Even with the build cache restored. I tried caching the entire home directory and it still fails.

The work around was to add the make build to the test-core job after restoring the env cache. It takes on average 23 extra seconds.

[bonjourmauko]

The test-core job fails if the build is not incorporated in the same job. I have no idea why. When running pytest alone, the yaml tests fail with a file not found error. Even with the build cache restored. I tried caching the entire home directory and it still fails.

The work around was to add the make build to the test-core job after restoring the env cache. It takes on average 23 extra seconds.

1048

[HAEKADI]

Hello @maukoquiroga! Since I rebased this PR the coverage went down to zero (for both make test-core and make test)with a CoverageWarning: No data was collected. (no-data-collected) warning. Which was not the case before the rebase 🤔 Do you have any idea why that might be the case?

[HAEKADI]

I tested deploy and the package is indeed published. But the documentation update is still problematic due to permission issues.

.

[MattiSG]

Thanks @HAEKADI! 😊 I updated the token to an “admin” scope, does it work now? 🙂

[HAEKADI]

@MattiSG Permission denied comes up still 😕

[MattiSG]

Mmh, I understand that I'd need to issue a personal token to get support for the API v1… I'm not so keen on that considering there is no scope limitation and I am admin on over 20 organisations. Could we consider using API v2 if it is not too costly? If that takes you more than one hour to put together, you can instead issue a personal token for yourself and send it to me in two pieces through side channels (e.g. Slack and SMS), I will then set it up 🙂

[MattiSG]

(as a side note, the deploy job should fail if update-doc fails, so we know…)

[bonjourmauko]

Thanks for considering me for review @HAEKADI 😊 .

I barely know Github Actions so I did what I could.

[HAEKADI]

Thank you for the feedback @maukoquiroga ^^

[HAEKADI]

@MattiSG I upgraded to CircleCI API v2 and added a personal token that I sent you.

[MattiSG]

I upgraded to CircleCI API v2 and added a personal token that I sent you

I don't think we needed both 😉 The current CIRCLECI_OPENFISCADOC_TOKEN should be valid for API v2. Could you please trigger a build and check that deployment works for you under these conditions? If not, I added the personal token you sent me under the CIRCLECI_V1_OPENFISCADOC_TOKEN secret. I will delete whichever one we don't need.

[HAEKADI]

I used both because according to the doc project tokens are not supported on API v2. I switched back to v1.1 because a trigger is needed to use v2 and I would have to modify the openfisca doc CircleCI config file in order to do so. As of now, the update doc step is functional with a personal token 🥳 I think this should be documented for future use. Should I do it directly with a comment in the workflow file or somewhere else?

[HAEKADI]

All that's left is to:

1. • [x] choose the Python patch version;
2. • [x] decide whether or not we're going to ignore changes to the tasks files;
3. • [x] update merge rules.

[MattiSG]

I switched off all requested checks. Please notify admins on Slack to set GitHub Actions checks as mandatory once this has been merged 😃