Fix message bug

[nikhilwoodruff]

This should fix #1072 . I'll add version change information, but the action seemed to fail quite quickly for some reason.

Technical changes

• Use self.entity.key rather than self.key when generating an error message for a mis-sized population array.

[nikhilwoodruff]

Thanks @benjello for the approval - just want to make sure this won't break anything, is there a reason the CircleCI changes are refusing to run?

[benjello]

@HAEKADI @MattiSG @maukoquiroga any hint about the failing CircleCi job ?

[HAEKADI]

After a rebase the new GitHub Actions config should run smoothly. The CircleCI check is just a leftover from the previous config and will be removed but it is not required for the merge. cc @sandcha

[sandcha]

Thank you @HAEKADI! Build stopped on CircleCI. cc @MattiSG
A rebase should solve the current building issue. Let me know if I can help on anything else @nikhilwoodruff :)

[MattiSG]

I triggered the build 🙂

As the CI says, the blocking point now is the version number that should be bumped.

@nikhilwoodruff can you update the CHANGELOG and setup.py? I think this is just a patch version update, so version 35.7.3 should be good 👍 Let us know if you need any help with this! 🙂

[MattiSG]

(as a side note, I suggest you git rm src/openfisca-core locally, as you accidentally added it as a submodule in https://github.com/openfisca/openfisca-core/pull/1081/commits/97fc9005a4dc271acfe15a94c457372ec61cca07)

[nikhilwoodruff]

Oh thanks @MattiSG - not sure how that happened. I've just added an entry to the changelog and bumped the version.

[MattiSG]

(I added a commit mostly to trigger the build, which apparently does not get triggered from third-party pull requests 🤔)

[HAEKADI]

@MattiSG I opened a PR #1083 to solve the issue.