Closed nikhilwoodruff closed 2 years ago
@benjello I added a test to cover this, should I add more? I think it covers the only use case.
@MattiSG @maukoquiroga we need an additional review here ;-)
Hey @sandcha @MattiSG @maukoquiroga - if you've got a spare second and this looks OK to add, would be much appreciated as we're having to use some workarounds in the US system (string type variable copies of affected Enums) that end up causing their own bugs. Thanks in advance!
Seems ok. I will make a review of this PR tomorrow.
@nikhilwoodruff From a "logistical" point of view, git rebase is favored in openfisca-core in order to get a linear history (easier to read etc.). Could you use git rebase instead of git merge?
You can for example compare their impacts by looking into the branch history with
git log --pretty=format:'%h - %an : %s' --date-order --graph
.
@nikhilwoodruff From a "logistical" point of view, git rebase is favored in openfisca-core in order to get a linear history (easier to read etc.). Could you use git rebase instead of git merge?
You can for example compare their impacts by looking into the branch history with
git log --pretty=format:'%h - %an : %s' --date-order --graph
.
Thanks @sandcha - I've updated the version number and changelog, so all the checks now pass. As for the rebasing, sounds good; I don't think I have permissions to merge the PR though?
Updating the versioning changes here after a recent PR was merged to ensure the versioning is still up-to-date here.
Thanks @benjello, @sandcha and @augusto-herrmann for the help with this PR!
This PR fixes a bug where
GroupPopulation.value_nth_person(EnumArray) -> Array[int]
, instead of the expectedGroupPopulation.value_nth_person(EnumArray) -> EnumArray
. I've extended the previous test case to cover this as well, to avoid code duplication.