Test Python 3.8 and remove Python 3.6

openfisca / openfisca-core

OpenFisca core engine. See other repositories for countries-specific code & data.

https://openfisca.org

GNU Affero General Public License v3.0

168 stars 75 forks source link

Test Python 3.8 and remove Python 3.6 #1111

Closed MaxGhenis closed 1 year ago

MaxGhenis commented 2 years ago

Technical changes

Test Python 3.8 (fixes #1035)
Remove Python 3.6 support in setup.py (fixes #1110)

Creating as a draft as I'm not sure I've done the Python version matrix correctly. I'm guessing some of the jobs should not be matrixed. I also need to adjust my linter.

NB: Python 3.8.12 is the latest version of Python 3.8, per https://www.python.org/downloads.

coveralls commented 2 years ago

Coverage increased (+0.02%) to 78.936% when pulling d91ecb8885f3e5e8551be31c53aa357ba2a86e7d on MaxGhenis:MaxGhenis/issue1035 into 49d95a08b8480b823a6e49b2ef16c8aeb8f0d196 on openfisca:master.

MaxGhenis commented 2 years ago

numpy 1.17.0 is failing to install on Python 3.8. I don't understand why it's starting at numpy 1.19.0 to retrieve the most recent three versions, rather than 1.22.0, which is the latest numpy version and compatible with Python 3.8 (not 3.7).

@maukoquiroga I'd missed your #1031 when starting this. Could this serve as a simpler starting point to at least get 3.8 running?

MattiSG commented 1 year ago

Thanks @MaxGhenis for this suggestion, and sorry for not having been able to collaborate on it to face the stronger complexity than it initially looked 😔 Superseded by #1168, which will hopefully provide a scalable way to test Python versions in a matrix. Looking forward to progressively bring support for newer versions of Python!