openfisca / openfisca-core

OpenFisca core engine. See other repositories for countries-specific code & data.
https://openfisca.org
GNU Affero General Public License v3.0
168 stars 75 forks source link

Release contains [dev] extra requires #1121

Open MattiSG opened 2 years ago

MattiSG commented 2 years ago

Hi there!

I really enjoy OpenFisca, but I recently encountered an issue.

Here is what I did:

make build

Here is what I expected to happen:

The resulting wheel file contains the production dependencies.

Here is what actually happened:

The resulting wheel file contains the [dev] extra requires.

Context

I identify more as a:

bonjourmauko commented 1 year ago

Hello @MattiSG !

I suspect this is because of the following line:

@find dist -name "*.whl" -exec pip install {}[dev] \;

There's a pull request open that solves this issue #1058

MattiSG commented 1 year ago

Thanks @maukoquiroga for the pointer!

1058 has been closed and superseded by #1068, and #1068 indeed replaces the provided line.