[conda] Fix comment replacement that crash conda build

openfisca / openfisca-core

OpenFisca core engine. See other repositories for countries-specific code & data.

https://openfisca.org

GNU Affero General Public License v3.0

168 stars 75 forks source link

[conda] Fix comment replacement that crash conda build #1127

Closed benoit-cty closed 2 years ago

benoit-cty commented 2 years ago

Connected to #1105 (and this comment)

Technical changes

The conda build failed on master because of a replacement in a comment string. I removed the _ in the comment to avoid replace in comment. These replace is made by the script .github/get_pypi_info.py that get info from PyPi.
With @sandcha we choose to remove the fonctionality that get dependencies from PyPi because it only works for main deps and not for extra requirements.

coveralls commented 2 years ago

Coverage remained the same at 78.922% when pulling 80af30366e84036df1233e5adfb1719376f2c801 on fix-conda-publish into 8496a92e5ff6bf4ab60293c51df5beb1e125e1b3 on master.

benoit-cty commented 2 years ago

Build tested locally with:

python .github/get_pypi_info.py -p OPenfisca-core
conda build -c conda-forge .conda

sandcha commented 2 years ago

Rebase on master in progress.

sandcha commented 2 years ago

Here is the list of the published openfisca-core packages: https://anaconda.org/search?q=openfisca-core The CI publishes to openfisca channel only as described in .conda/README.md.