search

openfisca / openfisca-core

OpenFisca core engine. See other repositories for countries-specific code & data.
https://openfisca.org
GNU Affero General Public License v3.0
170 stars 75 forks source link

Remove base attribute from ParameterScaleBracket #1162

Closed benjello closed 2 years ago

benjello commented 2 years ago

Depends on #1160

Breaking changes

This attribute is unclear and was used only for some French social security contributions

bonjourmauko commented 2 years ago

Too late to finally know what it did? I always thought it was some sort of bit wise feature.

benjello commented 2 years ago

@maukoquiroga : some french social security contribution (AGIRC-ARRCO, IRCANTEC, CSG, CRDS) have a theoretical rate and an actual rate with a corrective coefficient. We used base to host the latter to stick to the "law of unique source of truth". But not systematically, resulting in more confusion than convenience. So I prefer to remove it completely to force people follow the rule "explicit is better than implicit".

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.05%) to 77.666% when pulling 26c37c0b078c64b8513a48259ddd3f51b1beb37f on remove-taxscale-bracket-base into 0caf9fc15b64f6c429b82f0bb92f4b5d29812e4f on master.

benjello commented 2 years ago

@maukoquiroga : argh test fails after the bump ...

bonjourmauko commented 2 years ago

This was failing because of incompatible caches. Now just because its a major, requires #1160