search

openfisca / openfisca-core

OpenFisca core engine. See other repositories for countries-specific code & data.
https://openfisca.org
GNU Affero General Public License v3.0
165 stars 74 forks source link

[2/17] Document the data_storage module #1167

Open bonjourmauko opened 1 year ago

bonjourmauko commented 1 year ago

Part of #1061 Part of #1062 Part of #1063

New features

Technical changes

bonjourmauko commented 1 year ago

@benjello What do you think?

benjello commented 9 months ago

Hi @maukoquiroga : I am not sure I can review this PR since I am not qualified enough. May be @maukoquiroga @sandcha @benoit-cty or @eraviart can give you a better review than myself.

If you point me to some specific problem where I can actually help, I would do it.

bonjourmauko commented 9 months ago

Hi @maukoquiroga : I am not sure I can review this PR since I am not qualified enough. May be @maukoquiroga @sandcha @benoit-cty or @eraviart can give you a better review than myself.

If you point me to some specific problem where I can actually help, I would do it.

As it is, it is mainly documentation (moving the data storage is a breaking change, but can't be downplayed by doing a doublwe import).

However, I'd like to have your opinion in where this could go, maybe in a second pull request, or in this one:

  1. Packaging together Holder and Storage.
  2. Order storage to make it more easily extensible.

In principle, everything besides documentation (including types) and refactoring should be extracted into a second pull request, so this one can be patch or minor?

In terms of style, I'm trying everywhere to apply [[STYLEGUIDE.md]] (WIP).

benoit-cty commented 9 months ago

Hello Mauko, Can you run OpenFisca-France tests with this version of Core ?