openfisca / openfisca-core

OpenFisca core engine. See other repositories for countries-specific code & data.
https://openfisca.org
GNU Affero General Public License v3.0
170 stars 75 forks source link

Fix dependency conflicts #1179

Closed bonjourmauko closed 1 year ago

bonjourmauko commented 1 year ago

Fixes #1176

Bug fix

Note

A definite way to solve this issue is to clearly separate library dependencies (with a virtualenv) and a universal dependency installer for CI requirements (like pipx), taking care of:

  1. Always running tests inside the virtualenv (for example with nox).
  2. Always building outside of the virtualenv (for example with poetry installed by pipx).

Moreover, it is indeed even better to have a lock file for dependencies, similar to what is it proposed in #1015 (with pip freeze) or with tools providing such features (poetry, pipenv, etc.).

coveralls commented 1 year ago

Coverage Status

Coverage: 77.659% (-0.004%) from 77.664% when pulling 4f6ee1fd276c79d95cbdde4541cf667afc2a9b8a on fix-twine-flake8-deps into f7529a2f0da2447b2d7f960f48b5dc28c75ca198 on master.

bonjourmauko commented 1 year ago

Would be great if you could test it @eraviart . I did test it on the New Zealand's package and seems to work fine.

bonjourmauko commented 1 year ago

Thanks @eraviart . As I elaborate in https://github.com/openfisca/openfisca-core/issues/1176#issuecomment-1364935194, it does not make sense to me to yank 38.0.2 as it actually unblocks the problem introduced in 35.11.1 regarding importlib-metadata. Because we've already released several majors since then, it doesn't seem practical to yank all of these versions either, unless there is a consensus to do so. Therefore, I'll modify the CHANGELOG of this PR to reflect that, by recommending using this version, removing the has been yanked part.

bonjourmauko commented 1 year ago

Changelog updated to reflect that 38.0.2 actually restored a working publication.