Closed bonjourmauko closed 1 year ago
Would be great if you could test it @eraviart . I did test it on the New Zealand's package and seems to work fine.
Thanks @eraviart . As I elaborate in https://github.com/openfisca/openfisca-core/issues/1176#issuecomment-1364935194, it does not make sense to me to yank 38.0.2 as it actually unblocks the problem introduced in 35.11.1 regarding importlib-metadata
. Because we've already released several majors since then, it doesn't seem practical to yank all of these versions either, unless there is a consensus to do so. Therefore, I'll modify the CHANGELOG of this PR to reflect that, by recommending using this version, removing the has been yanked
part.
Changelog updated to reflect that 38.0.2
actually restored a working publication.
Fixes #1176
Bug fix
setup.py
setup.py
are not taken into account bypip
's dependency resolver.Note
A definite way to solve this issue is to clearly separate library dependencies (with a
virtualenv
) and a universal dependency installer for CI requirements (likepipx
), taking care of:virtualenv
(for example withnox
).virtualenv
(for example withpoetry
installed bypipx
).Moreover, it is indeed even better to have a lock file for dependencies, similar to what is it proposed in #1015 (with
pip freeze
) or with tools providing such features (poetry
,pipenv
, etc.).