Remove comments extraction not used and very slow on newer python versions

openfisca / openfisca-core

OpenFisca core engine. See other repositories for countries-specific code & data.

https://openfisca.org

GNU Affero General Public License v3.0

165 stars 74 forks source link

Remove comments extraction not used and very slow on newer python versions #1188

Closed guillett closed 12 months ago

guillett commented 1 year ago

Comments extraction is not tested, doesn't seem to be used and is making the API very very very slow.

I am currently refactoring this section, it remains the source code extraction and generation but for comments it looks simpler as the logic can be removed.

Breaking changes

In _Variable.get_introspectiondata:
- comments removed from the tuple returned

232 seconds spent for an unused feature here:

Screenshot 2023-07-10 at 18-30-38 full_7minutes_profile3

A single long findsource trace (and I'm working on it, I extracted that PR from my work)

Screenshot 2023-07-10 at 18-36-42 without_comments

coveralls commented 1 year ago

coverage: 73.985% (-0.005%) from 73.99% when pulling 3ec9c9fea41fabf399e51bea39d890818f2aa407 on faster-api into 94f68f4c876b0499de63af1a1e9bee6edda90983 on master.

guillett commented 1 year ago

I would like to merge this PR with #1189 to avoid two major version bumps. I will wait a couple of days and if it looks like it's better to split them, I'll merge them separately.