I suggest to wait until https://github.com/openfisca/openfisca-doc/pull/309 is merged to proceed with merging this PR, as it would be the ideal moment to change the ref to main rather than having an additional patch published later. The review is still relevant to have now thought, considering that the logic itself will not change.
If this PR is merged:
[x] CIRCLECI_OPENFISCADOC_TOKEN secret should be erased
[x] CIRCLECI_V1_OPENFISCADOC_TOKEN secret should be erased
coverage: 74.48%. remained the same
when pulling 005c5c6e2002bd4c76efe6538421ecf04f662b6a on deploy-doc
into 46c7c7e58c61c1ef62449154cf27c0d1d9f25806 on master.
Technical changes
Update documentation deployment trigger to adapt to https://github.com/openfisca/openfisca-doc/pull/308
Proof that the deployment is triggered can be found on the Doc Actions log.
Details of implementation and difficulties can be found on https://github.com/openfisca/openfisca-doc/pull/308#issuecomment-2121712431.
I suggest to wait until https://github.com/openfisca/openfisca-doc/pull/309 is merged to proceed with merging this PR, as it would be the ideal moment to change the
ref
tomain
rather than having an additional patch published later. The review is still relevant to have now thought, considering that the logic itself will not change.If this PR is merged:
CIRCLECI_OPENFISCADOC_TOKEN
secret should be erasedCIRCLECI_V1_OPENFISCADOC_TOKEN
secret should be erased