openfisca / openfisca-core

OpenFisca core engine. See other repositories for countries-specific code & data.
https://openfisca.org
GNU Affero General Public License v3.0
171 stars 75 forks source link

Upgrade OpenAPI spec to v3 #989

Closed MattiSG closed 1 year ago

MattiSG commented 3 years ago

Depends on #1160

New Features

Breaking changes

screenshot


Last updated by @maukoquiroga at 2022-11-03T23:14:44Z

bonjourmauko commented 3 years ago

Awesome 😃 !

@openfisca/international-maintainers if this is considered a problem to have WIP PRs in this repo, please feel free to close 🙂

I think that thanks to Github drafts, WIP pull requests have been more widely and less wildly used.

I may also have some time in the coming weeks to put into this, if you need some help, haven't tried yet but I guess the validation test that you added is to help follow through programatically with the upgrade?

MattiSG commented 3 years ago

I guess the validation test that you added is to help follow through programatically with the upgrade?

It is a way to know what's left to do, yes.

MattiSG commented 2 years ago

Interesting point to have in mind: there is a user request for customising some parts of the generated OpenAPI, see https://github.com/openfisca/openfisca-doc/issues/222.

bonjourmauko commented 1 year ago

I'd like to invoke #1159 and deploy a pre-release. @guillett would you like to test it with MesAides/1jeune1solution?

coveralls commented 1 year ago

Coverage Status

Coverage increased (+0.02%) to 77.659% when pulling be3dee5236d9a3f1c9b758dbf2d2223b66ba4c5e on openapi-v3 into 78c0d5f057bef53298f83f4143f9735617923c56 on master.

MattiSG commented 1 year ago

I'd like to invoke #1159 and deploy a pre-release.

I am not sure I understand the reason: this PR is barely 600 LoC, and most of it is about moving the contents of a YAML file around. Could you please clarify what makes you consider that “the changeset is too large for manual review”? 🙂