openfisca / openfisca-france-indirect-taxation

French indirect taxation module for OpenFisca
http://www.openfisca.fr/
GNU Affero General Public License v3.0
5 stars 13 forks source link

Attribute AbstractReform does not exist #152

Closed thomasdouenne closed 7 years ago

thomasdouenne commented 7 years ago

On branch energie-migration, when trying to use a reform (for instance, when we run the script "examples/master_thesis/loosers_within...py") we get the error message :

AttributeError: 'module' object has no attribute 'AbstractReform'

This comes from openfisca_france_indirecttaxation/tests/base.py There should be another way to call these reforms, any idea how to do it ?

benjello commented 7 years ago

I solved this problem partially. I let you finish the work.

Look at the unfinished rattrapage_diesel and base to finish migrating the reforms

Do not miss the TODO !

Let me know if you have any problem.

thomasdouenne commented 7 years ago

It is done. The only problem is that for this to work I had to go in "openfisca-core/taxbenefitsystem.py," in the function "add_variable", and change "update = False" to "update = True". Otherwise it does not take the new variables in the reform. Should I commit and push this change ?

benjello commented 7 years ago

Affichage update = True in the reform

thomasdouenne commented 7 years ago

Sorry I don't understand

benjello commented 7 years ago

Add update = True as a keyword argument when adding variables to the reform

benjello commented 7 years ago

@thomasdouenne : did you fix the thing ?

thomasdouenne commented 7 years ago

Not yet, do you need this to be fixed very soon?

benjello commented 7 years ago

Just want to know if you are still stuck

thomasdouenne commented 7 years ago

No it works well with the change of update = True in taxbenefitsystem so I did not tried yet to put this as an option in the function. I do this tomorrow.

benjello commented 7 years ago

@thomasdouenne : close this if it is done

thomasdouenne commented 7 years ago

Move to new issue: update reforms energies