openfisca / openfisca-france-indirect-taxation

French indirect taxation module for OpenFisca
http://www.openfisca.fr/
GNU Affero General Public License v3.0
5 stars 13 forks source link

Ident_men is empty in survey scenario #161

Closed thomasdouenne closed 7 years ago

thomasdouenne commented 7 years ago

When creating a survey scenario, the variable 'ident_men' gives an empty column. The variable exists in the tax and benefit system, and is correctly filled in the input dataframe.

Do you know what is going wrong?

benjello commented 7 years ago

idents are no more varaibles of the system If you want to keep it, you should create a variable on purpose

thomasdouenne commented 7 years ago

I don't understand since it appears in the tax and benefit system. How should I do to create this variable ?

thomasdouenne commented 7 years ago

What I don't get is why it differs from any other variable that I can use in a scenario. And what was the reason to not display ident_men? Do I have to create another one with another name?

thomasdouenne commented 7 years ago

The new variable to identify households is called 'numero_menage' and starts with the year of the survey, followed by the household raw in this survey.

benjello commented 7 years ago

I prefer identifiant_menage Ok for the numbering !

On Tue, Sep 19, 2017 at 2:13 PM thomasdouenne notifications@github.com wrote:

The new variable to identify households is called 'numero_menage' and starts with the year of the survey, followed by the household raw in this survey.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/openfisca/openfisca-france-indirect-taxation/issues/161#issuecomment-330519793, or mute the thread https://github.com/notifications/unsubscribe-auth/ABHxd7Wz_Z9qqCOP24oKL3nuzjJK2Cvhks5sj6_OgaJpZM4Pbbr1 .

-- Mahdi Ben Jelloul

thomasdouenne commented 7 years ago

I started with that but I didn't want to create confusion with ident_men so I switched to numero_menage. I will change it.

thomasdouenne commented 7 years ago

Done