Fix travis tests - Githubissues

openfisca / openfisca-web-api

[DEPRECATED] Web API for OpenFisca

https://www.openfisca.fr/

GNU Affero General Public License v3.0

13 stars 11 forks source link

Closed cbenz closed 7 years ago

cbenz commented 7 years ago

Connected to #82

Fix a bug in travis-run-tests.sh script which continued after make test fails – now it stops
Fix flake8 error
Specify OpenFisca-France constraints (only for travis tests) in .travis.yml
Remove the script which syncs git branches before testing

This will make #85 tests pass, and make it mergeable.

fpagnoux commented 7 years ago

Ce n'est pas lié à cette PR, mais je remarque que la version minimale de core pour faire passer les tests n'est pas 5.0.0 mais 5.0.1

cbenz commented 7 years ago

@fpagnoux Good idea to ignore empty lines, and moving CLI test to Makefile.

MattiSG commented 7 years ago

Ah, too late to the party… 8 minutes between “reviews welcome” and merge was a bit short :wink:

fpagnoux commented 7 years ago

The GitHub workflow for a PR with several committers is not clear, unfortunately. I approved the PR and @cbenz merged it :(.