search

openfisca / openfisca-web-api

[DEPRECATED] Web API for OpenFisca
https://www.openfisca.fr/
GNU Affero General Public License v3.0
13 stars 11 forks source link

Don't use git sha #56

Closed fpagnoux closed 8 years ago

fpagnoux commented 8 years ago

As it prevents the api from working out of a git repository.

Use the country package version instead, now that we have strict versioning.

Fixes the build.

fpagnoux commented 8 years ago

@MattiSG, I think you implemented this, I don't know exactly if you used it in the code or if was just for debugging, but let me know if you think there is a problem with this PR.

MattiSG commented 8 years ago

This is great!! The idea was just to output a version identifier as metadata in order to ease debugging. The Git SHA was just the best version identifier we had at the time, but if versioning and bumping is properly addressed, I'm more than happy to see the Git dependency go.

MattiSG commented 8 years ago

Btw, does this impact sgmap/openfisca-web-api#1?

fpagnoux commented 8 years ago

Thanks for unburying that ;) sgmap/openfisca-web-api#1 was also indeed deprecating the use of git sha.