Fix venv wrong path

[cbenz]

In some cases in /variables endpoint, source_file_path of each variable was wrong if application was deployed in a virtualenv. This fix uses importlib to get the path of the country package instead of pkg_resources.

[cbenz]

@fpagnoux @laem I added a label "review in progress"

[fpagnoux]

Is it a label you add when you are reviewing something, or is it the person who wants a review that adds it ?

[MattiSG]

And the label stays there once merged? ❓

[cbenz]

Haha, which label, I don't see one ^^

[cbenz]

@fpagnoux hmm, at first it's a call-to-review sent to the team, but if the PR author forgets to put the label, it is possible for the reviewer to add it when actually starting the review.

[MattiSG]

a call-to-review sent to the team, but […] reviewer to add it when actually starting the review.

🤔 I find this slightly ambiguous: as a possible reviewer, when seeing this label, am I supposed to review or is someone already doing it?

We do it with assignments: when an implementor has finished work, s·he unassigns herself. If a PR is open with no assignee, then it is waiting for review. Once a reviewer starts work, s·he assigns herself. Once review is done, reviewer unassigns herself and reassigns the original implementor. The original implementor can then work, and this cycles until a GTM is obtained, at which point the original implementor is expected to merge her work.

No need for a label to request reviews since everything is expected to be reviewed, no need for a label that says a review is in progress because for efficiency reviews should not be parallel.

[cbenz]

@MattiSG That's good. Just a detail: when you say "until a GTM is obtained", it means that the expression "GTM" is said via comments, by each reviewer, right?

[MattiSG]

Yup.