search

openfisca / openfisca-web-api

[DEPRECATED] Web API for OpenFisca
https://www.openfisca.fr/
GNU Affero General Public License v3.0
13 stars 11 forks source link

Remove dependency to OpenFisca-France #90

Closed cbenz closed 7 years ago

cbenz commented 7 years ago

OpenFisca-Web-API package should serve any country, thus it should not express any constraint to OpenFisca-France like it is on this line.

The thing is the Web API works with OpenFisca-France == 13.1.1 on https://legislation.openfisca.fr/ If we run the whole tests many will fail, but that's only those on deprecated features (field and graph endpoints)

Now what about removing this dependency constraint and create the right abstractions? From an architectural point of view it seems to me the right thing to do.

Any thoughts @openfisca/coreteam?

MattiSG commented 7 years ago

Yes, that's definitely the right thing to do, would it be only to avoid work like #92.

But this is an internal refactor that will have to be prioritised at some later stage :wink:

fpagnoux commented 7 years ago

This dependency has already been removed I think. @cbenz can you close the issue if it's the case ? Thanks !

cbenz commented 7 years ago

Yes: https://github.com/openfisca/openfisca-web-api/pull/92/files#diff-2eeaed663bd0d25b7e608891384b7298L48