Rename variables to follow France evolutions

openfisca / openfisca-web-api

[DEPRECATED] Web API for OpenFisca

https://www.openfisca.fr/

GNU Affero General Public License v3.0

13 stars 11 forks source link

Rename variables to follow France evolutions #92

Closed cbenz closed 7 years ago

cbenz commented 7 years ago

Comes before #91

A few variables are hard-coded in tests, and I'm pretty sure that's the only reason for having an explicit dependency constraint to France.

Then we'll be able to merge #91 because it needs on OpenFisca-France == 13.y.z.

cbenz commented 7 years ago

Should france make sure it can be served by the api, or should the api make sure it can serve france 🤔

It's more:

Web-API depends on Core
France depends on Core
as a consequence, if the version of Core satisfies both Web-API and France, then Web-API can serve France

fpagnoux commented 7 years ago

Yep, that's in theory, but there is some value to make sure it actually works :).

That's what these tests do. They are in web-api, but they reference france variables. I wonder where they should be located.

MattiSG commented 7 years ago

These tests should be rewritten to be independent from France, so that web-api has its own set of integration tests that rely on a DummyCountry with no churn.

Not asking for a rewrite, just giving a theoretical answer :wink: