search

openfl / lime-vscode-extension

Visual Studio Code extension for OpenFL and Lime projects written in Haxe
https://marketplace.visualstudio.com/items?itemName=openfl.lime-vscode-extension
MIT License
27 stars 4 forks source link

Missing libraries vs new "lime display failed" error #38

Closed Gama11 closed 1 year ago

Gama11 commented 6 years ago

This is a case where the new error is perhaps a bit misleading:

Too bad Lime handles -lib on its own, otherwise it could just be passed onto the Haxe Language Server, which would then create a proper diagnostic from it in the problems view. But I guess there isn't really a way for lime display not to fail here because of its custom lib handling...

jgranick commented 6 years ago

Perhaps the right approach is to test the Lime executable once on boot-up, and to display a message if this occurs. Otherwise, we only log to the console. This could occur due to any code compilation issue in the user's code as well

Gama11 commented 6 years ago

This could occur due to any code compilation issue in the user's code as well

Such as? I can't think of any other scenario where lime display would fail / exit with 1.

I think it's actually good that this pops up in an error box so it doesn't fail silently anymore, it's just that the hints don't help much here (neither lime setup nor lime.executable will do much good). Perhaps we should check if the output begins with Error: and show the error in the popup box instead in that case.

Gama11 commented 6 years ago

Another example:

The startsWith("Error:") check might be a good heuristic.

joshtynjala commented 1 year ago

The new 1.5.0 update of lime-vscode-extension includes a better experience when lime display fails.