search

openfl / lime-vscode-extension

Visual Studio Code extension for OpenFL and Lime projects written in Haxe
https://marketplace.visualstudio.com/items?itemName=openfl.lime-vscode-extension
MIT License
27 stars 4 forks source link

Remove Hashlink MacOS debugger catch #78

Closed rcstuber closed 1 month ago

rcstuber commented 3 years ago

Hi! For a few months Hashlink debugging on MacOS has been integrated. Someone pointed me to a issue with Lime and I found that there still is a legacy OS guard in the code. You can safely remove this block:

https://github.com/haxelime/lime-vscode-extension/blob/c6c3581ae6f556fe56a1bd97827d973e8523d62a/src/lime/extension/Main.hx#L874

Thanks!

Gama11 commented 3 years ago

You can safely remove this block:

No you can't, this requires a newer HashLink version, and Lime bundles HashLink (1.10 atm IIRC).

rcstuber commented 3 years ago

True, it requires Hashlink v1.12, my assumption was that dependencies are up-to-date always. @Gama11 Merry Christmas ;-)

jgranick commented 3 years ago

The blocker is getting new builds, ideally we want a copy of HashLink built using an older macOS version and using an older Linux version (like Ubuntu 16.04). HashLink only has official Windows builds

rcstuber commented 3 years ago

Since I don't think official HL Mac/Linux binaries are on the horizon anytime soon, maybe add a from-source compilation step to Lime for Hashlink?