search

openfl / lime

A foundational Haxe framework for cross-platform development
https://lime.openfl.org/
MIT License
761 stars 375 forks source link

undefine legacy pi driver #1635

Closed gepatto closed 1 year ago

gepatto commented 1 year ago

The legacy pi driver is preventing a successful rebuild of lime for the raspberry pi running a recent piOS (bullseye) because it will try to link to files that are no longer present on bullseye This driver wasn't very good anyway because it didn't have proper x11 support, wasn't able to set display resolutions and mouse support was buggy

As pi support is very new I don't think backwards compatibility is an issue here.

player-03 commented 1 year ago

Huh, looks like you defined it in the first place. You've been working on this for a while!

player-03 commented 1 year ago

I don't know why that convention exists, but I do prefer consistency. Just checking: does this still work?

gepatto commented 1 year ago

I have been trying to have support both the legacy and the new KMSDRM driver. My main piOS has been updated through versions. Therefore some files existed on my OS that are missing from a clean OS. So my builds WITH the old driver were still successful.

When I tried out a clean piOS install I noticed the files that are needed for the legacy driver are no longer there and compiling lime would fail. ( the old driver uses DISPMANX )

As for the #undef It might be ok to use the */ #undef style for consistency I'll try that first.

gepatto commented 1 year ago

I'm closing this pull request, I'm doing some more research first