openfl / lime

A foundational Haxe framework for cross-platform development

https://lime.openfl.org/

MIT License

761 stars 375 forks source link

Tweak audio behavior on iOS and Windows. #1646

Closed player-03 closed 11 months ago

player-03 commented 1 year ago

1558 made some changes to fix an audio issue on iOS. However, in #1638, @Vortex2Oblivion reported that this caused a new error on Windows. This pull request simply reverts #1558 on non-iOS platforms.

This isn't a perfect solution, but it should work until someone figures out the root cause of one or both errors.

player-03 commented 1 year ago

I wonder if #1009 is related to all this, but am not prepared to spend the time to figure it out right now.

player-03 commented 1 year ago

I wonder, does anyone else experience audio issues (static, cutting out, etc.) when targeting Windows C++? So far only one person reported this behavior, and he silently withdrew the issue.

joshtynjala commented 1 year ago

I keep meaning to try to reproduce the original issue and test the PR, but I haven't had the time yet.

joshtynjala commented 1 year ago

I tried various ogg and wav files that I had laying around with Windows c++ today, but I could not reproduce the issue in 8.0.1. Seems like the original fix may be fine.

player-03 commented 11 months ago

The original reporter long since closed their issue, and no one else reported it after nine months, so I think it should be good as-is.