Closed player-03 closed 1 year ago
Yes, this does have to be a bunch of separate commits. Otherwise, Git would show that 1245 lines were removed and replaced by 1245 new lines, not recognizing that any of those lines match, and it would be much harder to verify.
I'm not saying the "files changed" tab shows a very good diff, but it's a lot better than if I'd submitted this PR as a single commit. At least the lines almost still line up, rather than appearing hundreds of lines down.
To see good-quality diffs, look at the individual commits.
Apparently the formatter doesn't account for conditional compilation, so when it sees a block of code like this...
...it indents once per curly brace. So instead of duplicating these curly braces, we should put them after
#end
.