search

openfl / lime

A foundational Haxe framework for cross-platform development
https://lime.openfl.org/
MIT License
753 stars 365 forks source link

Fix warnings in Haxe 4.3. #1702

Closed player-03 closed 1 year ago

player-03 commented 1 year ago

Looks like Haxe is dropping support for @:enum abstract, and we'll have to use enum abstract instead. (Same with @:extern → extern.)

For now, all it does is generate warnings, but it can generate them after build-stopping errors, making it hard to find what went wrong.

joshtynjala commented 1 year ago

These warnings should be fixed in develop/8.1.0-Dev already. It should just need a merge from 8.1.0-Dev.

player-03 commented 1 year ago

Oh ok. I didn't check for that.

player-03 commented 1 year ago

I do still like #if haxe4 as shorthand for #if (haxe_ver >= 4.0), but whatever.

(Yes, #if haxe4 will remain true in versions greater than 4. After all, #if haxe3 is still true.)

joshtynjala commented 1 year ago

Yeah, I understand. I think I made some of the Flash externs use if (haxe_ver >= 4.3) so that some of the changes wouldn't be disruptive for those who haven't upgraded to 4.3 yet. So I probably just copied that and changed to 4.0 instead of switching to #if haxe4.