search

openfl / lime

A foundational Haxe framework for cross-platform development
https://lime.openfl.org/
MIT License
749 stars 362 forks source link

Added `android:appCategory`. #1724

Closed MAJigsaw77 closed 6 months ago

MAJigsaw77 commented 8 months ago

This pr is basically making an app able to be detected as a game on android.

MAJigsaw77 commented 7 months ago

Is there anything wrong with the pr?

player-03 commented 7 months ago

The implementation looks fine, but it seems isGame is deprecated.

MAJigsaw77 commented 7 months ago

The implementation looks fine, but it seems isGame is deprecated.

Maybe i should implement that instead

MAJigsaw77 commented 7 months ago

@player-03 what should be as default value?

joshtynjala commented 7 months ago

what should be as default value?

The Android docs say this:

Only define this value for apps that fit well into one of the specific categories.

With that in mind, by default, you shouldn't set it to any value. Just skip it entirely.

MAJigsaw77 commented 7 months ago

Will this be pushed?

player-03 commented 7 months ago

What do you think of #1735 as a solution?

MAJigsaw77 commented 7 months ago

What do you think of #1735 as a solution?

It's better then this implementation

MAJigsaw77 commented 7 months ago

You can close this if you want

player-03 commented 7 months ago

Might leave this open until we get more feedback on my version. Edit: merged.