search

openfl / lime

A foundational Haxe framework for cross-platform development
https://lime.openfl.org/
MIT License
754 stars 371 forks source link

Don't compile `armv7` if the `architecture` excluded it. #1745

Closed MAJigsaw77 closed 8 months ago

MAJigsaw77 commented 8 months ago

Previously only the ndll was excluded from being added to the app, now that part of the compilation won't even happen anymore decreasing the compile time.

player-03 commented 8 months ago

Well now there's no guarantee that any architecture will be selected. Maybe we need something like this at the end?

if (architectures.length == 0) architectures.push(Architecture.ARM64);
MAJigsaw77 commented 8 months ago

Well now there's no guarantee that any architecture will be selected. Maybe we need something like this at the end?

if (architectures.length == 0) architectures.push(Architecture.ARM64);

Right

MAJigsaw77 commented 8 months ago

Maybe was better to also warn the user but ok

player-03 commented 8 months ago

That would be fine too. I don't have any reasons to prefer either.

MAJigsaw77 commented 8 months ago

I think is done